koloz193
koloz193
this should probably be updated to include the namespace changes. here's a good reference pr for the 721 namespace changes https://github.com/OpenZeppelin/cairo-contracts/pull/296
@andrew-fleming should be good to review now!
> Very good work! Left some comments and suggestions. Also, please add documentation for the feature :) yea thats a good idea. ill add in some docs :)
@andrew-fleming yup getting to both this weekend
@andrew-fleming added the params and fixtures to the set tests, for the map i didnt feel like it cut down on enough
@andrew-fleming @martriay any update on this 😄
@andrew-fleming makes sense. i ended up doing a fresh refactor based on the current state of main
> @koloz193 ahh yeah, the rebasing conflicts must have looked like a nightmare yup, once i saw like 10 different files i quickly decided against trying to attempt the rebase
> awesome! will merge in main and clean it up!
@andrew-fleming @martriay any update on this 😄