Masoud Koleini
Masoud Koleini
This pull request requires documentation and unit tests to be included. In addition, there are indentation problems in the code that needs to be fixed. Please see https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md for the...
There are still some guidelines that are not followed, for instance: 1. Conditions with single likes don't have braces. See [Braces usage on conditionals](https://github.com/fluent/fluent-bit/blob/0374172adabc8f41e4cbc75ae9a54834a0e59293/CONTRIBUTING.md#braces-usage-on-conditionals-loops-and-functions) for the details. 2. Some variable...
Would be good to add tests if possible.
In addition to the fixes, a proper documentation on this plugin is needed. For instance, users need to know the definition of `batch window` and how it works for watermarking.
Thanks @unitmatrix, it would be great if the syntax (https://github.com/fluent/fluent-bit/tree/master/src/stream_processor#sql-statement-syntax) can be updated based on your changes as well.
Hi @unitmatrix, I reviewed the BNF syntax and looks like it requires further cleaning up, which will take care of it. I am just wondering if your test functions would...