Koichi ITO

Results 399 comments of Koichi ITO

I found that there will probably be breaking change in this PR. Please wait for a while due to I will investigate it.

The CI failure seems to be unrelated to this change. Aside from the issue this PR solves, .travis.yml will need to be updated for stabilize the CI.

> The default order of controller actions in rails scaffolds are: I agree with the default order if this rule is needed. I think it's better to follow the scaffold...

The N+1 query problem can be forcibly prevented, but there is a possibility of false making of unnecessary eager loading instead. So, `strict_loading` may be fine in most cases, but...

Thank you for sharing your opinion. These APIs were proposed by DHH and I think it is unlikely that it may change in future. https://github.com/rails/rails/pull/35316#issuecomment-560527408 > The argument `"by symmetry"`...

I think that this issue is solved in [RuboCop Rails gem](https://rubygems.org/gems/rubocop-rails). - https://github.com/rubocop-hq/rubocop-rails/pull/36 - https://github.com/rubocop-hq/rubocop-rails/pull/68 Please use RuboCop Rails gem when using Rails cops because these cops has been removed...

I think this is worth mentioning in the style guide. Can you open the proposal with example code to the Minitest Style Guide? https://github.com/rubocop-hq/minitest-style-guide

> In one of my projects, there are other matcher methods that are not a part of the core Minitest library (perhaps an extension) @gi I have a question. Are...

Can you update the parameter name to `ExtensionMatchers` and mention it in the documentation text?