kodinkat

Results 23 comments of kodinkat

![Screenshot 2024-05-21 at 14 14 01](https://github.com/DiscipleTools/disciple-tools-theme/assets/19330800/81df7dad-309a-4173-84c2-cae1d7795b03)

It would seem it's a size restriction issue; as the wp_comments table currently has a column comment_type `varchar(20)` size constraint; which will fail for longer types. ![Screenshot 2024-05-09 at 13...

@corsacca let me know how revised flow holds up for you...

Managed to reduce `./tests/test_phpcs.sh` errors; however, failing to [locate suitable sniff rules](https://gist.github.com/dakira/97d456d1d67ba42359a18bd1f2ddc92b) to exclude the following exceptions: - Opening brace should be on a new line - There should be...

Exceptions still not resolved by current sniff rules: - Expected 1 space before opening brace; found 0 - Expected 1 space after FUNCTION keyword; 0 found - Opening brace must...

403 Forbidden exception encountered whilst trying to directly access API; which I believe is the result of an abscent nonce. As a result, no updates are made to location field....

It would seem the Dismiss All functionality is working as intended; displaying the Duplicates Detected record tag and removing it following the clicking of Dismiss All option. ![Image](https://github.com/user-attachments/assets/3ff5c933-3ee2-4add-bf60-7300242458de) ![Image](https://github.com/user-attachments/assets/33bdccba-eb46-4421-8403-3585f1a844bd) However,...

> @kodinkat can you give an example of how this will be used? Hey @corsacca, see `dt_sso_login_response` function within corresponding [PR](https://github.com/thecodezone/dt-home/pull/206/commits/878a28121ec31b1d1b91d0af19c1bbbc99c95431); which aims to update `redirect_url` based on login outcome...

> @kodinkat how does this compare with using this filter? `$redirect_url = apply_filters( 'dt_login_redirect_url', $redirect_url );` @corsacca could it potentially be expanded to also accommodate sso payload and error data;...

> @kodinkat I think the default workflow would be to pass in or load the SSO login with the desired redirect instead of trying to determine the correct redirect after...