kmsheng comments

Results 25 comments of


                                            kmsheng

Github action worker hangs when tests in parallel have finished

I have similar hanging problem.

Healthcheck errors when there's no CNAME present

Same here.

Wonderful, but raises an issue. module.exports is in it

SAME HERE

`root` key for :attributes adapter is pointless

`json_key` should not be called when `attributes` adapter is used. object.class.model_name.to_s is not likely to get `model_name` correctly. For example, instances of `ActiveRecord_Relation` do not have the method `model_name` and...

Support for rewriting to external URLs

What date is today ? Why is this issue still open ?

Cannot add property autodllStatsRetrieved, object is not extensible

This project is dead.

fix infinite loop by parent attr

@apotonick Sure, my pleasure

fix infinite loop by parent attr

@apotonick Please take a look at https://github.com/trailblazer/reform-rails/pull/95/commits/1396f357f27f7e8881173b15dee5d2a549698e82 ，this test would fail at master branch.

fix infinite loop by parent attr

And the error would be thrown as ``` Error: ParentTest#test_0001_allows nested collection validation messages to be shown: SystemStackError: stack level too deep lib/reform/form/active_model.rb:92:in `new' lib/reform/form/active_model.rb:92:in `active_model_name_for' lib/reform/form/active_model.rb:87:in `model_name' lib/reform/form/active_model/validations.rb:31:in `block...

calling form.validate throws error stack level too deep

trace before validate ```rb $enable_tracing = false $trace_out = open('trace.txt', 'w') set_trace_func proc { |event, file, line, id, binding, classname| if $enable_tracing && event == 'call' $trace_out.puts "#{file}:#{line} #{classname}##{id}" end...