Kirk Mitchener

@liukun4515 this can be closed, right? proper comparison of decimal128 seems to be implemented and it's not converting to float64. https://github.com/apache/arrow-rs/blob/master/arrow/src/util/decimal.rs#L163

I think that rather than any options, the support for object_store should be invisible to the user. So just running this SQL from datafusion-cli should be enough to trigger the...

I want to highlight that I've entered issues (tracked in #3480) and commented out tests for some things that broke when using Decimal128. It does feel a bit like Decimal128...

Sure, I will switch it to draft and add another issue for changing the mathematical functions to accept and return decimal types in addition to float, where appropriate. That should...

@turbo1912 yes, and the object_store is new since then as well. Also, @timvw has just today published some cookbooks regarding object_store and s3 that may help with this: https://github.com/datafusion-contrib/datafusion-cookbook If...

Nice. tpch.rs for example does something like this. https://github.com/apache/arrow-datafusion/blob/master/benchmarks/src/bin/tpch.rs#L1044 Maybe also a corresponding read_batch() function for the same use case but where it doesn't need a table, but just needs...

When fixed, pls un-ignore test tpch_q17_correlated() in core/tests/sql/subqueries.rs

> 🤔 maybe we need to use `Decimal` type rather than `Float` for constants. When we initially ran TPCH we did not have support for this data type, but now...

Hm, I realize now I should be converting from float to Decimal128 :)

hi @liukun4515, no, with decimal its still not the right result and I'm not sure why yet. but it's much closer: ``` Left: ["123141078.23"] Right: ["123140554.79"] ``` I think it's...