Kevin McPhillips

Refactor and remove the weight/measurement methods with params on Package and PackageItem

3

Both the `Package` and `PackageItem` classes have methods to return weight and dimensions in all kinds of units. Moreover, those methods accept options hashes and parameters to modify the return...

Replace options with keyword args

1

Since we'll be dropping lower version support, we can use keyword args everywhere. #426 So many of the method signatures are like `(a, b, c, d, e, options={})` and those...

## Problem On any given CI run we skip over 100 tests: These are tests that need some kind of credential for a third party carrier that we cannot share....

Fix money parsing

1

`Package.cents_from` is a problem. https://github.com/Shopify/active_shipping/blob/e76c8c7314f7fbc6a3f7e66fa076624498c8bf39/lib/active_shipping/package.rb#L117-L131 It makes a bunch of guesses of how it thinks money is being represented, then parses with switch cases and some weird defaults. Plus assumes...

In tests we have lots of: ```ruby assert thing.property? ``` Which should all be converted to: ```ruby assert_predicate :property?, thing ```

Update Github Actions plugin in README.md

3

The originally recommended Github Action in the README has gone unmaintained and no longer works due to the Ruby version being too old. See: * https://github.com/andrewmcodes/standardrb-action/pull/20 * https://github.com/andrewmcodes/standardrb-action/pull/23 * https://github.com/andrewmcodes/standardrb-action/commits/main/...

Setting `default_job_options` with a symbol key has unpredictable results with duplicate keys

4

Ruby version: any Rails version: any Sidekiq / Pro / Enterprise version(s): 7.2.2 (but appears to be the same on `main`) Hi Mike! Long time user first time commenter. I've...