Kai comments

Results 10 comments of

Kai

Add support for all iPhone 12 models and iPod Touch 7G

Thanks for this project @schickling ! Would be great to see the newest devices in it, too.

Ability to resolve multiple implementations of same type

Valid question! To your first one: being able to resolve multiple instances of the same registered type is something I am used to when working with .Net. Microsofts Dependency Injection...

Ability to resolve multiple implementations of same type

@hmlongco I addressed your feedback about the nested containers. Can you please review?

Ability to resolve multiple implementations of same type

Didn't consider that. Made some additions and adjustments. @hmlongco

Ability to resolve multiple implementations of same type

Addressed your PR review comments @hmlongco Sorry for my delay this time (was on PTO).

Added optional blocks to define the show and hide animations of a toast.

I totally missed before that my code didn't build. Fixed this now. Maybe my enhancements could be considered now.

Added optional blocks to define the show and hide animations of a toast.

Thanks @scalessec !

Added optional blocks to define the show and hide animations of a toast

@scalessec Did you already consider pulling my additions?

Added optional blocks to define the show and hide animations of a toast

@scalessec might my additions have a chance to get in to your branch?

use of potential dangerous function strlen

Same happening on my end right now. Penetration test results marked usages of `strlen` and also `malloc` as high severity. Even though the code might check the correct usage, the...