Johan Klinge

Results 15 comments of Johan Klinge

I also checked this by calling the last.fm api directly with the parameters above. Tried with a number of different values for limit (itemsPerPage). Seems like it is working fine...

Is it ok if I have a go at implementing this?

I'll start with trying to get tests to run on .Net Core/Linux. If I fix that then I will continue with this one.

According to last.fm api pages "now playing" is now showed by passing a parameter in the call to GetRecentTracks. > Get a list of the recent tracks listened to by...

I did some testing of the Last.fm api for this. It seems that the "now playing" track is always returned regardless of if you send the nowplaying="true" parameter to the...

Integration testing would sort of require that you had a user that you knew always had a song playing. Otherwise you will not get the "nowplaying" attribute. The "RJ" user...

Never used or looked at the scrobble functions in the library. Will have to do that sometime.. :) Should I still make a PR for the added unit test I...

I had a look att the failing test ScrobblesSingle. The error is an assert that the actual and expected time the track was played is the same (expected = trackPlayed,...

Also looked at the error in UpdatesNowPlaying. This is an error because it seems LastFM now returns an array of ArtistImages in the track object. A number of other parameters...

Ran the tests today again. The error on the timestamp on the scrobbledTrack.TimePlayed is still there. Only change is that now it's off by more than 5 seconds. I also...