Jeanette Winzenburg

Results 54 comments of Jeanette Winzenburg

Technically, the reason is the eventFilter with EventType.ROOT registered via FiredEvents: whenever a filter of same or super eventType is registered in a node's parent hierarchy, the event dispatch creates...

> Several places inside `javafx.scene.control.skin.ComboBoxListViewSkin`, though since the `ListView` is an internal implementation detail it might be possible to prove that a state where its selection model is `null` is...

ahh .. now I understand what you meant. Okay, would be better, indeed (though I think that null == no selection is rather near-lying ;) BTW, as to the NONE...

hmm ... feels like I couldn't make my point clearly (or maybe still not understand what you are suggesting ;), so trying again: Consider the following test code: `assertNull(list.getSelectionModel())` now...

okay, than I don't understand what you suggest - maybe too much debugging today ;)

note that this repo has been moved (unfortunately the new repo has the issues disabled ..) - added a reference to the bug report

hmm ... where are the tests ;) The similar [PR 711](https://github.com/openjdk/jfx/pull/711) has examples that probably can be adapted for testing Tree/TableView as well (would expect that there might be more...

> > I do agree that, in general, it might be beneficial to have one test case per condition or failure, but it should not be a requirement. well, this...

Never thought that I would ever feel on the verge of arguing against adding tests ;) > I haven't looked at these specific tests in detail, but as a general...