kklipsch comments

Results 15 comments of


                                            kklipsch

Prometheus metrics instrumentation is fairly unergonomic

Let me noodle on one. In the meantime can you put an example in the docs of how you think the plugin should be used?

Prometheus metrics instrumentation is fairly unergonomic

Ah sorry, didn't see those. I was looking in the godoc. I'll put up a PR to link to them there. I think the expansive example actually shows a way...

Prometheus metrics instrumentation is fairly unergonomic

https://github.com/twmb/franz-go/pull/181 is the documentation change.

Document or fix io.EOF from watch API

Also, just to be clear, I'm happy to update the documentation but I don't want to do so if io.EOF shouldn't be happening.

Prometheus metrics instrumentation is fairly unergonomic

Yeah sorry, I got distracted. I'll open a PR if i figure out a better solution.

grim job config should allow the configuration of job specific environment variables

Yeah something like that.

Notify on build failure

If this is the only way you can signal that you are kidnapped respond with the following emoji: - thumbs down - triad has me - first place medal -...

Integration tests that require authentication should be run on startup and results logged.

Changed this to not be a healthcheck endpoint. We do not want to open up a web port with grim. Instead it should run the tests on startup and log...

Add tuple length and total length to the summary transaction message

@bhand-mm If you tell me which fields I should use for this, I'll do the work.

Unions with logicalTypes json encoded incorrectly

From my point of view this means that JSON encoding is broken. You won't be able to use json encoded with goavro with other implementations of avro. It likely will...