Kun Zhang
Kun Zhang
/assign @ptabor
> If I understand correctly, the only case we want to issue a warning is case that happens in line 72 of the original code: > > ``` > opts...
> Why the warning message in this PR is different from the message in [13747](https://github.com/etcd-io/etcd/pull/13747) ? > > This is a kind of enhancement, so in my opinion it should...
> This PR adds Sleep(2sec) to 3.5, so has potential to break customer's workflows thus cannot be accepted. > > I'm for submitting just warning+flag to 3.5, to let customer's...
It seems happend when write log. https://github.com/uber-go/zap/blob/6f34060764b5ea1367eecda380ba8a9a0de3f0e6/zaptest/logger.go#L130
I will work on follow tests： - [x] e2e/ctl_v3_compact_test.go https://github.com/etcd-io/etcd/pull/13770 - [x] e2e/ctl_v3_endpoint_test.go https://github.com/etcd-io/etcd/pull/13774 - [x] e2e/ctl_v3_defrag_test.go https://github.com/etcd-io/etcd/pull/13820 - [x] e2e/ctl_v3_completion_test https://github.com/etcd-io/etcd/pull/13825 - [ ] e2e/metrics_test.go
> Adding some reference from kubernetes. Looks like GCE defaults to `5s`. I could imagine graduation of the flag will be breaking change for etcd users so etcd-v3.6 release should...
I found this still do not backport to v3.4 and v3.5. I would help to do this.
/assign @thaJeztah
The failed tests seem not to be related to the change.