Kyle B. Johnson
Kyle B. Johnson
I can tackle this one.
@thekuom is this still an issue? I'm not able to replicate as of PUM v1.8.11 / NF v3.4.20 using https://gist.github.com/kjohnson/79dfd4f28b4c0a1754631052cd47d386
Closing in favor of feedback, see https://feedback.givewp.com/bug-reports/p/subscription-payments-fail-when-multi-level-donation-titles-are-longer-than-250.
> Looking at how we're running the static analysis on GitHub, I see we have another workflow. I then wondered, "Why don't we just include this as a job in...
> the tests workflow only runs on master and develop... but that doesn't seem right. The tests run when a PR is opened against `develop`, so that covers almost everything....
> But it would run for every push to a PR going to one of those branches? I just don't want someone to know they're failing static analysis only after...
> we should probably have static analysis run on PHP 7.2 and PHP 8.0. I'd like to catch issues on our min and max PHP versions supported. I can add...
> we should probably have static analysis run on PHP 7.2 and PHP 8.0. I'd like to catch issues on our min and max PHP versions supported. - [x] 7.2...
On a related note, there seems to be a lot of duplication between the "unit tests" workflow in the shared repo and the "wordpress tests" workflow in GiveWP. If we...
@JasonTheAdams it looks like we left off with QA on August 29. I'm following up now. Other than that I'll resolve the merge conflicts and have this ready for final...