Kathy Jang
Kathy Jang
Oops sorry this was not ready for review yet -- but we'll clean up the comments, and it is ready for review now. thanks for your comments!
Linking with pull #944. LGTM after the build passes
Once that's fixed, LGTM!
Actually I'm curious, what happens when there is no leader, so a vehicle's headway automatically returns min(1000, env.network.scenario_length..)? Your code doesn't actually change this logic, so I'm wondering about how...
Also caught one more spot that requires changing, in the update function in vehicle/traci.py around line 222 : self.__vehicles[veh_id]["headway"] = 1e+3 self.__vehicles[veh_id]["follower_headway"] = 1e+3
> > Actually I'm curious, what happens when there is no leader, so a vehicle's headway automatically returns min(1000, env.network.scenario_length..)? Your code doesn't actually change this logic, so I'm wondering...
@acjoseph The traceback indicates that departLane isn't set correctly. This is set in the experiment script (i.e. flow/examples/stable_baselines/traffic_light_grid.py and flow/examples/rllib/traffic_light_grid.py). What are you setting your departLane to? As the traceback...