Kishor Patil comments

Results 6 comments of


                                            Kishor Patil

[STORM-3702] Change thrift exception classes to contain getMessage() method

@bipinprasad As discussed, I feel all the thrift API methods thould wrap these exception under `TException`. So we can consistently ensure message/cause is passed down to the client side. Currently...

[STORM-3054] Add Topology level configuration socket timeout for DRPC Invocation Client

@HeartSaVioR @revans2 sorry for delay in addressing the review comments.

exclude org.glassfish.web:javax.servlet.jsp from storm-autocreds hbase-server dependency

The travis build failures are related to `MODULES=Check-Updated-License-Files`

[STORM-3132] Avoid NPE in the Values Constructor

@revans2 @HeartSaVioR Now constructor allows `null` values.

[STORM-3132] Avoid NPE in the Values Constructor

@HeartSaVioR Removed unwanted condition.

[STORM-3565] add support for adding dimensions to metric data points

Having _DimensionalCountMetric_ is excluding all other IMetric implementations that would required Dimensional implementation.