Kirk Brauer

Results 41 comments of Kirk Brauer

@roji What do you think about adding the basic client-side API for manipulating and querying the cube? I think that the cube type is specific enough that it needs the...

That makes sense, I forgot about the specific advantages of the 'IReadOnlyList' interface. I also agree that we should limit the client-side API to the bare minimum operations to start...

@roji The maximum size of each list is 100 elements, so `AddDimension` might be warranted, of course we have to determine if this method returns a new instance of the...

That makes sense, if the list sizes get out of sync, we can just pad the opposite array with zeros when serializing or displaying the string rep.

@roji No worries, I got a bit busy last week, but I'll push a new updated version with the changes we discussed above when I get a chance.

@roji Quick question regarding the public shipped API vs public unshipped API. Which file would be the best to place the declarations for the NpgsqlCube so we can run the...

@roji Doing it right now.

@roji All squashed and rebased. We should be ready for merge, though we might need to do a little work on the tests first.

@roji I'm working on adding additional tests for the cube type, however I have run into a very obvious problem related to our reference optimizations. If the cube is a...

I've been thinking about the best way to go about this. I feel that options 2, and 3 are probably off the table because they introduce additional complexity/confusion that would...