kioba

Results 9 comments of kioba

As far as I know, there could be multiple `LENS_FACING` and `LENS_FACING_BACK` hardware but we always return the first one. we have to also take `LENS_FACING_EXTERNAL` into consideration https://developer.android.com/reference/android/hardware/camera2/CameraMetadata.html#LENS_FACING_EXTERNAL The...

@Muhannad508 thanks for the link! That is good to know 👍

One of the reasons to have nullable type is compatibility with java. Giving a meaning to null is what we intend to avoid. @illuzor gave a great point on this.

`onDestroyView` is a different lifecycle event for fragments, Moving the `disposables.dispose()` before the `super.onDestroy()` does not solve it. calling `detach` on a fragment inside a `fragmentTransaction` actually triggers only `onDestroyView`...

If the initial intent filter is used we take only the first initial intent and the rest won't be triggered as long as the _ViewModel_ is not destroyed.

@nateridderman the `disposables.clear()` solved an issue where returning to the list of TODOs the last added one was never shown. Thanks for the suggestions! 👍

I will go and figure out why the refresh event is triggered. What I can see is if we change the initial intent solution it won't trigger multiple times on...

I will take a look at this today :) Thanks for splitting the work!