Zack King
Zack King
Found a small bug when testing. - Change Rotation Strategy to `Index Time` - Toggle `Rotate Empty Index Sets` and save the config - Rotation period should be shown as...
@danotorrey that's correct. The list will need to be filtered of any Illuminate caches/data adapters and we may want to also look at a strictly backend check so that calls...
Looks like a lot of extraneous commits have been picked up in this PR. Once it gets to a good spot, it may be worthwhile to create a new branch...
> Not sure if this would be a problem for instances without the security module, maybe we can call staticReferencedSearchBinder somewhere in graylog2-server where we know it'll always get bound?...
I think these utility methods are nice! I took a stab at rewriting TDIR's largest DB service using them and it was straightforward and (to me) cleaned things up a...
@danotorrey did you create an event definition with a user other than `admin`? I think it needs to have ownership checks hitting the DB before those warnings pop up.
I'm closing this for now. We will likely handle something like this in a more sweeping change to event definitions as a whole.
@danotorrey I've been working through a few minor details in this specific PR to fix that issue and others. Hopefully should have it all wrapped up early next week!
@bernd first round of feedback has been addressed. `StreamImpl` is gone along with setters and the dangerous raw map functions. May be some test cases that still need cleaning up,...
Thank you for all of the feedback along the way, @bernd! 🎉