kimikage
kimikage
I'm in favor of the `adaptation()`, though there is room for consideration of the name and order of arguments.
The time passed while I was waiting for Julia v1.x and its packages to be stable. I'm going to implement `adaptation()` by taking the following steps. 1. Add the white...
## About step 1 Current `whitebalance()` has a problem with the [pre-](https://github.com/JuliaGraphics/Colors.jl/blob/e08950fe9e24a5848d408c3576d6ebf275f4e435/src/algorithms.jl#L36)/[post-](https://github.com/JuliaGraphics/Colors.jl/blob/e08950fe9e24a5848d408c3576d6ebf275f4e435/src/algorithms.jl#L48)conversions which depend on the white points. For example, a `Lab` color should be converted to `LMS` via `XYZ`...
[WIP] https://github.com/JuliaGraphics/Colors.jl/compare/master...kimikage:cat
## About step 2-3 Let's decide the function name! - cat - :smile_cat: short - :crying_cat_face: kitty? catenate? - adapt - :smile_cat: short - :crying_cat_face: confusing with adopt - adaptate...
## About step 4 Although I can write tests for the behavioral specifications such as the round-trip testing or type checking, for the quantitative testing, the numerical and concrete examples...
> What you are doing here is really Von Kries chromatic adaptation As you (@KelSolaar) have mentioned, the current `whitebalance` and the very function what **I need** (i.e. linear Bradford...
> Complex chromatic adaption models have much more inputs Yes. So I'm going to pass the buck to input CAT object. Not `Type` but CAT `struct` object is passed into...
@johnnychen94, I also think supporting broadcasting is important. On the other hand, I don't think it is a fatal problem for users to write the wrapper functions or lambdas, though....
I will do the step 1 (adding the white point argument), after the cleaning up the conversion methods (issue #354). And then, what about replacing the `wp::XYZ` to something like...