Kia King Ishii

Results 226 comments of Kia King Ishii

Thank you so much for the PR! Yeah this kinda makes sense. It doesn't address the issue of dynamic module registration but seems like it's better than the current where...

Commit massage should be fine, we can squash and rename it when merging the PR 👍 Though the test code should be added before merging. But, please let's wait until...

@ktsn Hi! Just checking in here 😳 Any thought on this issue?

Yeah, I think this addition is a little too much? But I do understand sometime people gets confused, or not sure how to pass multiple argument. So how about we...

> An alternative would be to provide these in a separate library, and users could use to include that, too, if you want to keep core very small and simple....

You can't use `mapXXX` helpers inside `setup` hook. And `useXXX` helpers are not there too. Please wait until this issue is being tackled! 🙇

Confirmed. This is happening due to caching issue. If we revert 0006765 it fixes. I think registering new getters is causing some kind of problem. Not sure what that is...

OK, this is happening because Vue is destroying the `computed` (Vuex getters) when the component is destroyed (switching the route). Not because of multiple module registration. We might not have...

I've opened #1883 with the failing test case.

@StephenBeirlaen Thanks for the feedback! Could you clean your repo a bit more? I can't find `state.int` you are mentioning. I'm not sure what I'm looking for here 😳