Kiaresch Mussawisade comments

Results 13 comments of


                                            Kiaresch Mussawisade

`${name}-${version}-runnable.jar` is not found in deployment directory

Hi @fvarrui I didn't change the configuration in our pom.xml . The only thing i changed was the version number of the java packager from 1.7.2 to 1.7.3 and suddenly...

`${name}-${version}-runnable.jar` is not found in deployment directory

In git i found that in 1.7.3 in the class `io.github.fvarrui.javapackager.maven.CreateRunnableJar` the line (number 91) `element("finalName", name + "-" + version)` is removed in the new Version. This could be...

`${name}-${version}-runnable.jar` is not found in deployment directory

Hi @fvarrui, I see the change in `maven-jar-plugin`. [Here](https://issues.apache.org/jira/browse/MJAR-233) is explained how to define the `finalName` in the correct way and if I define the `finalName` in our `pom.xml` as...

`${name}-${version}-runnable.jar` is not found in deployment directory

> Are you setting `finalName` in your POM? I mean ... maybe this was causing this issue by modifying `maven-jar-plugin` behaviour, since `CreateRunnableJar` expects a different JAR filename. yes. exactly....

`${name}-${version}-runnable.jar` is not found in deployment directory

Hi @fvarrui . I tested the snapshot `1.7.4-20230821.162917-2` and it works. I even changed the `finalName` and the JavaPackager can deal with it. Best, Kia

`${name}-${version}-runnable.jar` is not found in deployment directory

Hi @fvarrui . the issue is unfortunately still there in the case of `mvn clean install` . I tested the snapshot version with your fix with `mvn clean package` where...

`${name}-${version}-runnable.jar` is not found in deployment directory

Did you try `mvn clean install` ? with `mvn clean package` is everything fine.

`${name}-${version}-runnable.jar` is not found in deployment directory

Hi @fvarrui Now it seems that every thin is fine. I tested both `mvn clean package` and `mvn clean install` on linux, mac and windows platforms with the snapshot version...

`${name}-${version}-runnable.jar` is not found in deployment directory

Thank you very much for your quick responses and fixes.

`${name}-${version}-runnable.jar` is not found in deployment directory

Hi @fvarrui At which time are you going to release 1.7.5 ? best, Kia