Khoa Nguyen

Results 12 comments of Khoa Nguyen

I also add some comments from David's: > Perhaps we should think about out-sourcing the mutex and the vector of persons to an extra struct, so that we can avoid...

There is still an error in the Pycode. The `mio::CustomIndexArray ` could not be bound since the `pymio::bind_CustomIndexArray` function does not include an overload for a tuple of doubles (just...

Basic functionality is implemented and is ready for review. However, the benchmark test is much slower than the `main` branch. Optimization is needed.

Still 35% slower than the benchmark test so there's some room for optimization. --------------------------------------------------------------------------- Benchmark Time CPU Iterations --------------------------------------------------------------------------- abm_benchmark/abm_benchmark_50k 3736 ms 3729 ms 1 abm_benchmark/abm_benchmark_100k 7858 ms 7844 ms...

Improved performance for the implementation with test results stored in the past. Branch main: --------------------------------------------------------------------------- Benchmark Time CPU Iterations --------------------------------------------------------------------------- abm_benchmark/abm_benchmark_50k 2281 ms 2255 ms 1 abm_benchmark/abm_benchmark_100k 4908 ms 4619...

We also need to add all checks for different VirusVariants in check_constraints() of parameters.h

> Thanks for fixing this. It might also be relevant for `SeverityProtectionFactor` and `InfectionProtectionFactor`. Have you checked this? I have checked them (see `TEST(TestInfection, getPersonalProtectiveFactor)`). I think they are initialised...

> Ah, yes, they have a different type. Why did we decide again that HighViralLoadProtectionFactor does not depend on age/virus type? Was this a result of some article? Yes, I...

Since I could not find a detailed paper/article mentioning directly how the HighViralLoadProtectionFactor changes over time, some observations from the following paper: https://doi.org/10.1186/s12916-021-02220-0 and https://doi.org/10.1371/journal.pone.0243597: **Data Overview:** - Initial Peak...