Khoa Huynh comments

Results 5 comments of


                                            Khoa Huynh

🚀 Feature: Better error for `--file` option with non-existent file

Wasn't exactly sure if you wanted to keep the red `Error` so I have it in these two ways on my local branch. Lmk your preference and I can push...

🚀 Feature: Better error for `--file` option with non-existent file

Good point, I don't think we need the call stack and I'm not sure a diagnostic output like Jest's or Vitest applies here. Currently `--file` doesn't search under a glob...

🚀 Feature: Better error for `--file` option with non-existent file

https://github.com/mochajs/mocha/pull/5086 ready for review 👀

Fix test "Expect insert in read only transaction to be rejected" that started failing

Is this still an issue? Can't seem to find the failing CI run and unable to reproduce on my machine. ![Screenshot from 2024-01-23 21-54-11](https://github.com/knex/knex/assets/58313491/f72fc81a-a4b1-4915-b649-aefb3777573b)

feat: Add error handling for nonexistent file case with --file option

> Looks like one test is failing, can you take a look? That was my bad, I forgot to pass the mocha instance as a parameter to the `handleUnmatchedFiles` helper...