Krisjanis Gaidis comments

Results 16 comments of


                                            Krisjanis Gaidis

Calling `FirebaseApp.configure()` bricks push notifications via no call to `didRegisterForRemoteNotificationsWithDeviceToken`

Seems like I can replicate with a simple sample project. Here is a ZIP of it. It pretty much has the code I pasted above. [RandomPush.zip](https://github.com/firebase/firebase-ios-sdk/files/5937356/RandomPush.zip) Edit: Likely code: -...

Calling `FirebaseApp.configure()` bricks push notifications via no call to `didRegisterForRemoteNotificationsWithDeviceToken`

Adding key `GoogleUtilitiesAppDelegateProxyEnabled` value `NO` to the applications Info.plist fixes this issue. Prints: ``` 7.5.0 - [GoogleUtilities/AppDelegateSwizzler][I-SWZ001011] App Delegate Proxy is disabled. ``` Docs: - https://git.webteam.tools/isaev.ta/firebase-ios-sdk/tree/d686427cc006863a617ab0a9b031eeef90a0224c/GoogleUtilities/AppDelegateSwizzler#disabling-app-delegate-swizzling-by-app-developers Of course, not sure...

Calling `FirebaseApp.configure()` bricks push notifications via no call to `didRegisterForRemoteNotificationsWithDeviceToken`

Here is an idea that I'm not sure if its right, but might as well throw it out there... Does it set the associated object on the original delegate? -...

Calling `FirebaseApp.configure()` bricks push notifications via no call to `didRegisterForRemoteNotificationsWithDeviceToken`

I'm building a new app and got stuck on this again for 1+ hour What saved me was this StackOverflow comment: - https://stackoverflow.com/a/51518574/826435 ...but then I realized I had encountered...

There's no way to filter out countries

@yuki-stripe If we added a configuration (ex. `availableCountries`) to `PaymentSheet.Configuration` and then fed that value into `CountryPickerDataSource`, would that be sufficient? The one problem I see is that the value...

Support for feature to hide postal code form in a specified country in PaymentSheetUI

This is possibly fixed? - https://github.com/stripe/stripe-ios/commit/c2bf06a51970f0659aea5faf5c9bb46cce0fa2e7

Swizzling for automatic check

@fastred I would +1 on exploring the ability to swizzle. I might be missing something, but it sounds like swizzling could be lot more maintainable in the long-run. To fix...

Can there be an easier way to get a full version of the code?

@chh51 I understand, and agree, that it's not easy to update these types of things and that constant changes do not make it easy to maintain. I would side with...

Calling `FirebaseApp.configure()` bricks push notifications via no call to `didRegisterForRemoteNotificationsWithDeviceToken`

@chliangGoogle > I'm not able to reproduce this issue Below I attached a ZIP that shows a very easy, reproducible case. See the `AppDelegate.swift` class that has some notes. [EasyTest.zip](https://github.com/firebase/firebase-ios-sdk/files/9720183/EasyTest.zip)...

Git Fatal on Danger Branches

Having a similar issue that sometimes is there, and sometimes isn't (has been happening on-and-off for the past year or so): ``` fatal: Couldn't find remote ref refs/heads/danger_base fatal: Couldn't...