Koen François
Koen François
I've tried a few things to make this work with Storybook defining its own type for signal, but there are instances of [unique symbol](https://www.typescriptlang.org/docs/handbook/symbols.html#unique-symbol) that I can't get around. I'm...
@arnoud-dv I believe this one's good to be merged, wdyt?
Nice catch @arnoud-dv ! Thank you for checking this out. @ShacharHarshuv I added a test in https://github.com/kfrancois/query/commit/eb05ac27314401d551e76e962ad58c758cd79a04#diff-aa4e4fa79cbfdc8cb15c0cfb49c3b858294ec82865c5e2cdbf0ba98e2927dfe4R459-R502 which I verified fails with the current implementation. If you think this can...
@LukasMachetanz thank you for logging this issue! Before we can work on this issue, could you provide some more information around the expected/current behaviour, or perhaps a reproduction? I've tried...
@LukasMachetanz sorry for my slow response here - my personal opinion is that the current behaviour makes sense in most cases, as we'd want to pass in the type that...
Sorry @LukasMachetanz, I thought I responded to this already - I can agree with your reasoning, would you like to drop a PR which swaps the generic type for this?...
Hi @ashutoshpaul! I think the current behavior is valid - it's still possible to edit fields by doing something like: ```ts const spectator = createComponent(); spectator.component.age = 12; spectator.component.id =...
Potentially, we could use `document.body.contains(node)` instead of checking for equality on a removed node, but I'm not sure about possible performance implications here (since we're traversing the DOM on every...