Kevin Rushforth
Kevin Rushforth
One more request: Please follow the instructions [here](https://github.com/openjdk/jfx/pull/395/checks) to enable running pre-submit tests.
I think it's some sort of GitHub permission issue. I was hoping that once people were added to the OpenJDK org anyone in that org could self-request a review (or...
One meta-comment: > @yososs yososs force-pushed the yososs:8253086_Optimization_of_removeAll_and_retainAll_of_ObservableListWrapper branch ... As indicated in the [CONTRIBUTING guidelines](https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md#submitting-your-changes-via-a-pull-request), please don't force-push to your branch.
Before I review the actual proposed change, I have a pair of related high-level questions that I should have asked at the beginning of this review. 1. What is the...
I understand that this will improve the performance of this method in some cases (but not all as you correctly point out), but what I really meant by my questions...
> * new BitSet(c.size()) > > Don't you notice this mistake? It certainly isn't an exact size, and probably not a very good guess in many cases (e.g., a small...
It would be more convenient to ask the developer set `VSCMD_DEBUG` via an env variable, rather than asking them to edit `win.gradle`. That way, the instructions would be: ``` export...
/reviewers 2