Kevin Rushforth

Results 600 comments of Kevin Rushforth

One quick comment. Compiling or running the apps should not need any additional `--add-exports`, `--add-reads`, or `--add-opens` arguments, and they should not need to load the shims or junit. Those...

Even if you use the Eclipse-generated class files, apps shouldn't need anything from the unit test infrastructure (which is the reason for needing all those `--add-exports`). Since I'm not an...

@Maxoudela please edit the title as follows: 1. Remove the space before the `:` (that extra space is why jcheck failed) 2. Change the text of the title to match...

> I'm sorry for posting the Pull request like that No problem. I mainly wanted to make sure that you knew why the RFR wasn't sent. As for the note...

The test failure is almost certainly due to not having the native WebKit libraries. Two options: 1. You can build WebKit yourself (it's fairly painless on Mac) by running gradle...

@Maxoudela are you interesting in pursuing this?

No hurry. I was just going through PRs that hadn't been updated in a while.

@jaybhaskar Can you also review this?