Kevin Ohashi
Kevin Ohashi
Was this ever fixed? Running into same issue now.
@Supericy I'd love to get this merged in, I just haven't had time to really check and go through the code. Thank you so much though for contributing. If anyone...
If anyone else wants to try this out and let us know what you think, if it's good, it can be merged.
You can submit a pull request, it's the easiest way to get code integrated into the repo On Fri, Dec 9, 2016 at 7:16 AM, toalt wrote: > Someone with...
It actually looks like a mistake in the library itself ``` php //returns a summoner's id public function getSummonerId($name) { $name = strtolower($name); $summoner = $this->getSummonerByName($name); if (self::DECODE_ENABLED) { return...
Let me know if that fixes it, I will patch the library :)
I really need to sit down one of these days and go through a bunch of fixes, it hasn't been well thought out lately. I haven't had the time to...
it could be, but I haven't had the time to maintain this library as well I should lately. I am looking through it and it's me quickly patching stuff and...
I appreciate the offer, if you want to look through and see what you think is wrong, how you would change it, I'm always open to help and ideas
I'm confused what this is trying to do or add to the library? It looks like you created a function to get a summoner by name passing in a name?