Kevin Wu comments

Results 5 comments of


                                            Kevin Wu

[CLI-2360] Revoking Auth0 refresh token on cloud logout

> Have you manually tested, that IsSSO field in get ccloud credentials is always correct? yup! It's the same code that used to exist in `login/command.go`, but I just moved...

MINOR: add ReconfigurableQuorumIntegrationTest

@chia7712 I'm continuing Colin's work in this PR: https://github.com/apache/kafka/pull/17582. Can you take a look when you get the chance? Thanks!

KAFKA-17803: Changing KafkaMetadataLog#read to match MockLog#read behavior + correcting LogSegment#read javadoc

> LGTM, but can we have some kind of test of the MockLog behavior? Yeah I can add that.

KAFKA-17803: Changing KafkaMetadataLog#read to match MockLog#read behavior + correcting LogSegment#read javadoc

@junrao Thanks for the reviews! Let me know if there's anything else.

KAFKA-19851 Delete dynamic config that were removed by Kafka

Thanks for the discussion @ahuang98 @0xffff-zhiyan: > I don't necessarily agree with allowing a user add a bad config - this could become a vulnerability if we don't have a...