kenhuuu
kenhuuu
Hi, thanks for contributing. I have a few questions/comments about this PR. 1. It seems like the retry logic may have been missed for submit_async(). 2. Maybe we should consider...
I don't completely follow the changes being made here but they seem to be well tested so my VOTE is +1.
Thanks for you interest in contributing. There has been a lot of interest around adding this support in the past. This is the open Jira issue for reference https://issues.apache.org/jira/browse/TINKERPOP-2143. The...
> But optionally we can change the supported node version to LTS, which is 20 right now if you guys think that is best. It's against our current runtime policy...
You are targetting this PR against the master branch which is currently for the next major release (4.0). The way our branching system works is that you target the lowest...
> @kenhuuu regarding the user agent header [used](https://tinkerpop.apache.org/docs/current/dev/provider/#_graph_driver_provider_requirements) by Gremlin server > > This is likely a separate discussion, but `User-Agent` header might not be the best way to identify...
VOTE +1. Thanks again for your willingness to contribute. It is much appreciated. I'm not sure if you are familiar with our policy but it takes a VOTE+1 from three...