Kendal Harland

Results 7 comments of Kendal Harland

Why not use hashCode in your == definition? ```dart bool operator ==(other) => other is TaskInvocation && hashCode == other.hashCode; int get hashCode => name.hashCode ^ (const IterableEquality().hash(positionals) * 3)...

Hi @dabrahams sorry for the breakage. This is likely because in the latest version I've removed an internal, implicit call to `gha-setup-vsdevenv` which happens on Windows after the Swift installation....

I understand the sentiment, but I think in this particular case, the cost of that one extra line to run `gha-setup-vsdevenv` again explicitly is a net improvement given that it...

@tkremenek can you please help me by adding the `flakey-test` label to this issue, as well as the others listed in [this query](https://github.com/swiftlang/llvm-project/issues?q=is:open+is:issue+author:kendalharland+%5Bflake%5D+)? I don't have write-access to issue labels,...

@adrian-prantl this test is not flaky on Windows upstream from what I observe. This flake only happens for me in swiftlang's llvm-project fork,, so I believe the bug belongs in...

https://github.com/swiftlang/llvm-project/pull/9103 will need to be cherry picked into swiftlang/swift/stable/20230725 when it is merged.

Hi @JDevlieghere! Apologies as I've been out on vacation. Would you please take a look at this change?