Damian Bogel comments

Results 19 comments of


                                            Damian Bogel

Support Interceptor Wrapping

Is my understanding correct that we don't need anything extra to support this case? Maybe just a GoDoc example?

Provide an ergonomic way to do per-handler interceptor configuration

Could you please clarify?

Provide an ergonomic way to do per-handler interceptor configuration

WDYM "protect single handlers" here? As in, install an `InterceptorConfig` per handler, or what?

Allow users to provide their own router

Figure out how to interact with other routers (like gorilla).

plugins/staticheaders: Add a `Vary: Cookie` header by default

MDN: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Vary. I agree that for now we should add the value to the `Vary` header, but we might consider actually having a separate plugin to control `Vary` (or other...

plugins/staticheaders: Add a `Vary: Cookie` header by default

The issue with having this in the core of the framework rather than a plugin is harder migration, because we usually don't offer opt-outs from core features. That being said,...

plugins/staticheaders: Add a `Vary: Cookie` header by default

EDIT: Nevermind, I misremembered what was in this thread. Anyway, it seems that @empijei is in favor of adding it to the core of the framework too. Up for grabs....

Add a high-level design document

this should not have been closed.

Add a high-level design document

ETA: EOW

Add a high-level design document

What remains: - [ ] resolve `safehttp` godoc TODOs - [ ] developer guide