Koichi Nakanishi

I would fix things you point out. Please review them.

`Nginx::SSL.accept_client`のテストを書くのが手間で止まっています。 他の指摘は問題なく修正可能です。 `Nginx:SSL.accept_client`のテストには x509として有効であり値として不適切である自己署名ではないx509証明書が必要です。 これを作成する方法とそれが適切であるとする条件が纏めきれていません。 証明書発行まわりは不勉強なので時間がかかりそうです。

I'm sorry `SSL_CTX_set_next_proto_select_cb` is client-side API so it will be dropped. It seems that almost hooks are useful and no problem to imlement. Maybe, providing ephemeral key exchange hooks to...

@bradleyfalzon Thank you for your review. I'd fix that the functions writing XXX use provided buffer and replace duplicated code to unexported function.

@bradleyfalzon > I'd think there should just be one function that both MediaSegment.String() and *MediaPlaylist.Encode() call. > Unless there's a specific reason we can't do that? I agree but there...

That's good idea. I'd like to show all infomation when the context is not provided. I think better like this. ```golang func (seg MediaSegment) write(buf bytes.Buffer, p *MediaPlaylist, durationCache map[string]float...

benchmark resutls ### Env - CentOS 7.4 - go version go1.8.3 linux/amd64 ### result ``` [m3u8]$ go test -bench=. BenchmarkDecodeMasterPlaylist-12 50000 29740 ns/op BenchmarkDecodeMediaPlaylist-12 100 21899250 ns/op BenchmarkEncodeMasterPlaylist-12 1000000 1426...

It would be good it is same result to media segment part of `(p *m3u8.MediaPlaylist) String() string` When all `m3u8.MediaSegment` field is presense, `(p *m3u8.MediaPlaylist) Decode()(byte.Buffer, error)` and `(p *m3u8.MediaPlaylist)...