Keerthi Vasan S A comments

Results 9 comments of


                                            Keerthi Vasan S A

Fix #34746: Add a size limit for variable size when pretty printing exception report

Please let me know if we can continue with this approach I will add the limits for other data structures as well if so!

Fix #34746: Add a size limit for variable size when pretty printing exception report

Hey @nessita, thanks for the go ahead! One of the problems I found is the old tests seem to be relying on some of behaviours with `pprint` that are not...

Fix #34746: Add a size limit for variable size when pretty printing exception report

@felixxm I think the PR is ready for review!

Fix #34746: Add a size limit for variable size when pretty printing exception report

Gotcha, thanks! Sorry this is my first time using Django Trac system so I don't know how to operate it. Hopefully it will be smoother in future contributions. I have...

Fix #34746: Add a size limit for variable size when pretty printing exception report

I just thought of something else. If we use `reprlib` for collections, it will only limit the number of elements. but let's say we have a list of strings where...

Fix #34746: Add a size limit for variable size when pretty printing exception report

@nessita Cool, i'll merge with the latest changes and fix the test cases now!

Fix #34746: Add a size limit for variable size when pretty printing exception report

@nessita The tests were failing because the implementation of `reprlib` differed between Python 3.11 and 3.10, there was no way to customize the fillvalue in Python 3.10 reprlib. So I...

Fix #34746: Add a size limit for variable size when pretty printing exception report

@nessita The only difference is we can't provide fillvalues to the `reprlib` meaning, In 3.11 We get something like `[1, 2, 3, 4,.... ]` But in 3.10 it's always `[1,...