Keeran Rothenfusser
Keeran Rothenfusser
@KaustubhIMG looks good to me from the code side of things. They look like nice implementations, and if you get some performance numbers on hardware, I'd be interested in knowing...
@KaustubhIMG now that you say it, it seems obvious from the implementation. You are carrying around 8 vector registers for accumulators, and loading 16 vector registers worth of data in...
OK, looks good from my point of view then. I can't do any more on the merge request apart from comment and say that :)
@KaustubhIMG No more comments from my side. The change looks good to me
> @fbarchard @dsharlet @bhbruce @keeranroth, If you have time, please help review this PR. @oliIMG @KaustubhIMG happy to give a review, but I'm not sure what operation this is. Can...
There is a pull request open for comments at https://github.com/oneapi-src/oneDAL/pull/2737
@icfaust I think that this issue can be closed. We still need some implementations for some of the statistics functions that currently don't call through to anything on Arm or...
All looking good from my point of view, thanks