Kedar Joshi

Results 9 comments of Kedar Joshi

I think the method should return an empty collection instead of `null` ```java if(isEmpty(source) || searchKey == null ) { return Collections.emptyList(); } ```

Also, length of the `source` can be cached for better performance e.g. ```java for (int i = 0, length = source.length(); i < length; i++) { if (searchKey.equals(source.charAt(i))) { indexList.add(i);...

> I do not reproduce the issue using the provided sample with embedded tomcat. It's reliably reproducible with dedicated Tomcat instance.

`ImmutableArrayStack` implements `ImmutableStack` which conflicts with `AbstractRichIterable` at least for `countByEach(Function

I wanted to take this up but not sure if it's still valid requirement.

I think I should also add `@Since` on new methods. Right ?

> Can you break the additional changes which you have .. Sure.

> my idea is to add a new field "Line height" in the editor options as a number input. The default value will be 1.4 (the current used value) That's...