Kris Borchers
Kris Borchers
IMO, it seems like anything with "needs review" should still be surfaced in FastPass because now that I know FastPass is hiding actual issues, FastPass is no longer useful to...
@rxaviers would you mind adding a checklist for each feature we should test for each component based on the Globalize API?
Hi @fdecampredon. Are you still interested in working on this?
I agree with @rxaviers here. I am working on adding some initial tests to the repo (PR almost ready) and then I will add this "use `this.props.value` if set, otherwise...
@rxaviers a review would be great. Also, I wanted to add the ability to use `value` prop in the `FormatMessage` component for consistency in the `react-globalize` components but when writing...
> About the empty message, technically it's an easy change, but I'm wondering why would you want to internationalize an empty string? Would it be different in other locales? Definitely...
Thanks @necolas, I will try to look into this tonight. It's been quite a while since I've touched this project and there are likely many conflicts to resolve but I...
Thanks for the feedback! I want to try to better understand your use cases and also pull in @rxaviers who is the expert on the Globalize side of this project....
I do think this makes sense and am not sure if Globalize has this feature but I would agree that it would be a good feature to add (option to...