Matthias Kay comments

Results 300 comments of


                                            Matthias Kay

Fixed git describe --tags returning an invalid semver string

When is 1.0-77-xxxx returned? As we start with 1.0.0 it should never happen. `git describe` returns 1.0.0-77-xxxxx

Error when using Yor in pre-commit on windows

Works on my machine with Windows 10. Golang is in the path.

Yor is writing temp.[0-9]+.tf files instead of changing the source code

Hm, the output says "passed". Are there logs available? ``` $ git commit -m "testr" [WARNING] Unstaged files detected. [INFO] Stashing unstaged files to C:\Users\kayma\.cache\pre-commit\patch1653467778-2272. yor......................................................................Passed [INFO] Restored changes from...

Yor is writing temp.[0-9]+.tf files instead of changing the source code

`pre-commit run -v --files main.tf` did it. `[WARNING] Unable to get git blame for file main.tf: failed to get blame for latest commit of file main.tf because of error file...

Yor is writing temp.[0-9]+.tf files instead of changing the source code

Tried with `0.1.150`. Error is still there. Also did a `git blame my-file-name.tf` before doing the `yor` command. `git blame` works fine. Note: My pipeline jobs are using the Alpine...

EC2 instance type

Have you checked https://github.com/thejohnfreeman/ami-gitlab-runner ? You could choose the M6g instance type.

Fix formatting and docs during pre-commit?

Github action: Format Terraform code: https://faun.pub/format-your-terraform-code-with-github-actions-2ce3ccdd6fb6

Fix formatting and docs during pre-commit?

Seems that it was already in place. Guess I didn't use pre-commit on my developer machine due to missing Python, argh. But I added support to format all files recursively.

Fix formatting and docs during pre-commit?

Seems that the docs are created in the `develop branch`. Can we do it for the formating as well?

Fix formatting and docs during pre-commit?

@npalm Shall we update the Github workflow to format the code as well? Found an action to do that: ``` - name: terraform fmt uses: dflook/terraform-fmt@v1 with: path: my-terraform-config ```...