Kathryn Baldauf
Kathryn Baldauf
@jterry75 @kevpar what is the status with this?
@jterry75 Sounds good! @kevpar, @dcantah, and I discussed this and we're fine with the change so long as it's marked deprecated, as you mentioned.
@thaJeztah @kzys btw
> Also, I'm not familiar about the role go-runc plays in LCOW and WCOW. Passing signal strings allow us to defer the cross-platform conversion and doing that in higher-level components...
@kzys Per our discussion yesterday, what are your thoughts on this?
> Left a suggestion; perhaps would be good to add a unit test as well to verify the behavior (order of preference / conversion) @thaJeztah Are you recommending adding tests...
@thaJeztah afaict there's no way for us to capture what's actually sent to the runc command without adding more functionality to the kill func to pass in our own IO....
@thaJeztah Any thoughts on what tests would be best here given my last comment?
@thaJeztah added!
What is the best path forward then here? @thaJeztah