karlmcdowall
karlmcdowall
I think this should be fixed :) One question I have is how to test/validate? If anyone has ideas I'd love to know...
There are a few cases in the `close-stdout.sh` GNU test that fail because println! causes a panic when stdout points to `/dev/full`.
I've posted my prototype implementation [here](https://github.com/Detegr/rust-ctrlc/pull/126/files) to hopefully help with the discussion. Thanks
Changes for this are done [here](https://github.com/uutils/coreutils/pull/7438)
Fixed [here](https://github.com/uutils/coreutils/pull/7438)
> > Changes give large performance improvement. > > Can you attach a benchmark to show the improvement ? The performance improvements are seen when the input comes in via...
In addition to the main changes here, I also made a few changes to add/remove buffering (`BufReader`/`BufWriter`) through the `head.rs` file - I've remove some buffering that was redundant and...
> Appart from the typo. this looks good ^^ It's nice to see such performance improvement 🚀 Thanks for the review!