Mohammad Karimi-Fard

Results 6 comments of Mohammad Karimi-Fard

Hi, Have you checked if `kgdViscosityDominated_poroelastic_benchmark.xml` is exactly the same for "`develop`" and "`develop 94e338c`" cases? Thanks!

> @karimifard @TotoGaz any update? So far I haven't find anything "wrong". At this point the performance difference seems to be due to nonlinearity treatment. Essentially the update of the...

Yes, it is lagging but it's happening within the nonlinear iterations so when the solution has converged at a given time step all quantities are up to date.

> > > Any updates on this PR? > > > > > > No further updates. I believe this Pull Request should resolve the performance problem. If required, I...

> > For now I am unsure though how to factor up this > > https://github.com/GEOS-DEV/GEOS/blob/6919bfb04393cae7ff7a336a5ae635dbd2118f59/src/coreComponents/finiteVolume/FaceElementToCellStencil.hpp#L244-L263 > > > > As unlinke halfWeight in TPFA, the treatment is non-symmetrical for...

We may also need a backup plan for highly distorted elements.