Kapil Lamba
Kapil Lamba
Can i work on this feature?
First commit contains changes via the script using basic mode. The second commit introduces minor adjustments to the test files: - Decided to retain `expect info` & `expect warn` statements...
Apologies for the delay here—got caught up with work and personal life. I've addressed the comments now, please take a look. Thanks for your patience!
Tagging @beorn7 and @NeerajGartia21
hey @beorn7 @NeerajGartia21 I am right now hardcoding the directory path: "promql/promqltest/testdata", do we need to make it configurable? Saw this comment: https://github.com/prometheus/prometheus/issues/15794#issuecomment-2632407046 We have 3 modes now: tolerant, basic,...
> Thank you very much. > > I still have to look at the code in detail. (Maybe @NeerajGartia21 will beat me to that. :) > > However, one note:...
Thanks for reviewing @beorn7, I’ve implemented the doc updates you suggested. Have also rebased the [strict migration mode PR](https://github.com/prometheus/prometheus/pull/16585) with this PR