Kang Hyojun

Results 14 comments of Kang Hyojun

It worked for me in my CRA app(with Typescript). ```typescript import ace, {Ace} from 'ace-builds'; import React from 'react'; import AceEditor from 'react-ace'; import 'ace-builds/src-noconflict/mode-sql'; import 'ace-builds/src-noconflict/theme-github'; import 'ace-builds/src-noconflict/ext-language_tools'; const...

[this code](https://github.com/spoqa/import-order/blob/master/import_order/cli.py#L16) might be problem.

I think it is nice to see an informative error message when the required field is missing on package.toml. ``` $ nirum -t docs -o ./out/docs/ . Metadata error: FieldError...

As I mentioned earlier, there are some style issues. ``` src/Nirum/Targets/Python.hs:850:1: too long line (107 chars) src/Nirum/Targets/Python.hs:850:108: trailing (1) white space src/Nirum/Targets/Python.hs:875:1: too long line (92 chars) src/Nirum/Targets/Python.hs:876:57: trailing (1)...

@dahlia @Kroisse Could you all review the idea of this PR regardless of the failing of CI? We decided to support [external tag](https://serde.rs/enum-representations.html) by adding `@external-tag` annotation on record type....

Nope 😢 Compiler gives metadata like __nirum_version__. But nirum runtime dosen't check metadata. It has to be done after modify nirum python runtime.

it could be implemented by using subcommand like ```bash $ nirum quickstart project name? ... version? ... target? ... ```

We could benchmark `npm init` comamnd.

@dahlia @Kroisse Have you had any suggestions?

[POSIX Extended Regular Expression](https://en.wikipedia.org/wiki/Regular_expression#POSIX_extended) sounds good to me. Should we validate regular expression in an annotation when `.nrm` file is compiled?