Ryuta Kamizono

Results 6 comments of Ryuta Kamizono

Looks like there is no reason to change the permission 644 to 755. ![image](https://user-images.githubusercontent.com/12642/70292421-95891d80-1821-11ea-8f29-7356021e72b1.png)

FYI the section for Rails 5 was added in #6 since at that time Rails 5.0.0 have the race condition https://github.com/sonots/activerecord-refresh_connection/issues/5#issuecomment-231568014. That was already fixed by https://github.com/rails/rails/pull/27057 and backported https://github.com/rails/rails/commit/fd21a5736b857a0f38c2617bf6e83515aeee755a...

`_read_attribute` and `_write_attribute` are a private API which had introduced at 08576b94ad4f19dfc368619d7751e211d23dcad8 (be2b98b4ae3397149b713b774e415143c88c4fb7) and #29495 to bypass the slower parts that checks for attribute aliases and custom primary keys. You...

If we don't intend to bypass attribute alias resolution, we can just use the `read_attribute` public API. Now, `read_attribute` has also been improved as much as possible. See 5575bd7b22e8e11ba8e2fdac4a92aab931d4f9f9, #36052,...

In other words "You can fix the association's attribute checks to aware of attribute aliases" in https://github.com/rails/rails/pull/45633#issuecomment-1198464204, if we revert be2b98b4ae3397149b713b774e415143c88c4fb7, the script in #45632 will pass I think.

I also tried to fix the timezone issue over 7 years ago (#28393, #28391). Unlike mysql2/trilogy adapter, postgresql adapter sets the timezone correctly, that is why `CURRENT_TIMESTAMP` works correctly with...