Kalyan Krishna
Kalyan Krishna
> services.AddOptions() add one line comment stating this is where the API support is added --- Refers to: 2-Call-OwnApi/daemon-console/Program.cs:24 in 8f4119e. [](commit_id = 8f4119e31779d3d64b2b5c0e332ed0e5f9f166ab, deletion_comment = False)
> "TenantId": "[Enter here the tenantID or domain name for your Azure AD tenant]", use standard text for comments --- Refers to: 2-Call-OwnApi/daemon-console/appsettings.json:4 in 8f4119e. [](commit_id = 8f4119e31779d3d64b2b5c0e332ed0e5f9f166ab, deletion_comment =...
> var clientSecretPlaceholderValue = "[Enter here a client secret for your application]"; I'll suggest we drop this and rely on azureAD options only --- Refers to: 2-Call-OwnApi/daemon-console/Services/ConfidentialClientApplicationService.cs:30 in 8f4119e. [](commit_id...
> public async Task GetAuthenticationResultAsync() might consider renaming it to more verbatim one like GetAccessTokenForApi() maybe? also return the token and handle exceptions.. --- Refers to: 2-Call-OwnApi/daemon-console/Services/ConfidentialClientApplicationService.cs:61 in 8f4119e. [](commit_id...
> public class ConfidentialClientApplicationService : IConfidentialClientApplicationService Please consider commenting heavily --- Refers to: 2-Call-OwnApi/daemon-console/Services/ConfidentialClientApplicationService.cs:11 in 8f4119e. [](commit_id = 8f4119e31779d3d64b2b5c0e332ed0e5f9f166ab, deletion_comment = False)
> public interface ITodoService consider commenting heavily --- Refers to: 2-Call-OwnApi/daemon-console/Services/ITodoService.cs:8 in 8f4119e. [](commit_id = 8f4119e31779d3d64b2b5c0e332ed0e5f9f166ab, deletion_comment = False)
> public interface IUploadTodosService nit: replace upload with "Post" --- Refers to: 2-Call-OwnApi/daemon-console/Services/IUploadTodosService.cs:7 in 8f4119e. [](commit_id = 8f4119e31779d3d64b2b5c0e332ed0e5f9f166ab, deletion_comment = False)
> public class TodoService : ITodoService This needs extensive commenting --- Refers to: 2-Call-OwnApi/daemon-console/Services/TodoService.cs:16 in 8f4119e. [](commit_id = 8f4119e31779d3d64b2b5c0e332ed0e5f9f166ab, deletion_comment = False)
> public class UploadTodosService : IUploadTodosService consider using "Post" or "Add" instead of "Upload" --- Refers to: 2-Call-OwnApi/daemon-console/Services/UploadTodosService.cs:9 in 8f4119e. [](commit_id = 8f4119e31779d3d64b2b5c0e332ed0e5f9f166ab, deletion_comment = False)
> defaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", authenticationResult.AccessToken); Explicitly and clearly call out that Access token for the API received from MSAL is added here to the request --- Refers to: 2-Call-OwnApi/daemon-console/Services/TodoService.cs:132...