kahagerman

Results 11 comments of kahagerman

> We just hacked our way around this by actively setting `target-branch: main` for one config, and leaving it unset for the other config (obviously only limited to 2 configs)...

> The glob you mentioned is correct since it only matches the first level assuming you only have folders there: > > > Vitest will consider every folder in `packages`...

@treardon17 Note that there was a breaking change made for workspaces in v2.1.0, check the [release notes](https://github.com/vitest-dev/vitest/releases/tag/v2.1.0).

> > This is not actually the issue I am reporting, though it is related. > > Typically when globbing, a trailing `/` indicates to only match folders, not files....

Ok, I see what you're saying now; I misunderstood your original comment. I wonder if it's worth using a more mature glob library if tinyglobby doesn't support this today.

Would it make sense to upstream this issue to `fast-glob`, and see whether they consider it to be a bug there?

Arguably, `**/*.js/` should _never_ match `/hello/world.js`, since there is no sequence of characters that you can replace the `*`'s with to make these identical. `**/` would be the exception that...

It seems to me that the implementation of https://github.com/rollup/plugins/pull/1783 is flawed. Versions

@marekdedic from your experiments, do you think an upstream fix to rollup itself could feasibly resolve this limitation?