Kafuu Chino comments

Results 15 comments of


                                            Kafuu Chino

WIP, DO NOT MERGE *: handle auth invalid token and old revision errors in watch

I clone locally, tried a run and the problem was solved, the previous watch will also be send by `nextResume`. However, because the default `WatchID = 0` is returned by...

watch stream return "permission denied" if token expired

The context on server side never change after stream created, so the token won't refresh, subsequent watches will fail after the token expires. PerRPCCredentials only called once when the stream...

watch stream return "permission denied" if token expired

@mitake ok, I will check PR: https://github.com/etcd-io/etcd/pull/14322 later.

Fixed unexpected cancelled watch with WatchID=0.

I found some comments that said watchID starts at 0, I don't know if there are any other effects.

Fixed unexpected cancelled watch with WatchID=0.

@ahrtr Let me explain in detail: 1. First, `WatchCreateRequest` does not set the value of `WatchID`, so `WatchID = 0`. ```go func (wr *watchRequest) toPB() *pb.WatchRequest { req := &pb.WatchCreateRequest{...

Fixed unexpected cancelled watch with WatchID=0.

I looked at the commit history and restored `creq.WatchId` to -1.

Fixed unexpected cancelled watch with WatchID=0.

@ahrtr @mitake Help review it sometime.

Fixed unexpected cancelled watch with WatchID=0.

@mitake Sure, I've squashed and rebase to the latest commit.

Fixed unexpected cancelled watch with WatchID=0.

@ahrtr Like this?

Fixed unexpected cancelled watch with WatchID=0.

@mitake That's the idea for my local test. 1. Watch a key. 2. Watch a new key and enter this code https://github.com/etcd-io/etcd/blob/main/server/etcdserver/api/v3rpc/watch.go#L271. I set the `--auth-token-ttl` of the server and...