Kestin Goforth

icon indicating a website link kest.in icon indicating an email [email protected]

icon company Stern Laboratories Inc. / 3D Parts Plus / Additive Performance icon location Grimsby, Ontario, Canada icon location Please don't steal my API keys.

Results 4 comments of Kestin Goforth

G02 or G03 are not interpreted as arcs in the gcodeviewer

This seems to be a result of the following lines: https://github.com/OctoPrint/OctoPrint/blob/a2e9aefe9c8a51120931e9b14bb95ebf9ea6c7f5/src/octoprint/plugins/gcodeviewer/static/js/viewer/worker.js#L482-L485 https://github.com/OctoPrint/OctoPrint/blob/a2e9aefe9c8a51120931e9b14bb95ebf9ea6c7f5/src/octoprint/plugins/gcodeviewer/static/js/viewer/renderer.js#L1074 The `.charAt(1)` in both checks will return `0` for `G02` and `G03` commands, meaning `direction` doesn't get set...

Fix/4493 - Defer M20 commands until initial capability report is done

I've realized another potential bug in this approach: the server will block all calls to `refreshSdFiles` if the printer firmware never reports any 'cap:' lines. This may not be a...

Fix/4493 - Defer M20 commands until initial capability report is done

Thanks for the feedback. Thinking more about this, I may prefer the 'Assume LFN Support' option because it doesn't modify the original command order or timing. A fourth option is:...

Fix/4493 - Defer M20 commands until initial capability report is done

Thanks for the input, I've refactored my code to better match the firmware_info implementation and added an event hook. I also created a quick test plugin for the hook: https://github.com/kForth/OctoPrint-AfterReportTest...