Kazuki Tsujimoto
Kazuki Tsujimoto
@palkan Sorry for late review. Could you update NEWS.md if possible? Then, I'll merge this. > 1. Both Symbols and Strings could be passed as the required keys, the type...
@palkan Thanks for updating NEWS! I added some review comments, could you check it?
@andrykonchin It seems failed spec is not related to the change, so I merged your PR. Thank you!
It seems a third party's issue. I added following debug code, ``` diff --git a/vendor/bundle/ruby/2.6.0/gems/power_assert-1.1.5/lib/power_assert.rb b/vendor/bundle/ruby/2.6.0/gems/power_assert-1.1.5/lib/power_assert.rb index 7eaa5f9..996f03e 100644 --- a/vendor/bundle/ruby/2.6.0/gems/power_assert-1.1.5/lib/power_assert.rb +++ b/vendor/bundle/ruby/2.6.0/gems/power_assert-1.1.5/lib/power_assert.rb @@ -53,6 +53,7 @@ def trace(frame) end...
Thanks for your PR. I am neutral on your proposal. However, I have the following concerns. * Should this feature be enabled by default? It may remove useful information from...
Thanks your PR. Ruby core team plans to implement new API to get position of AST node (https://bugs.ruby-lang.org/projects/ruby-trunk/wiki/Node-position-memo). So I think power_assert should use it to support muliple lines.
[PowerAssert.trace](https://github.com/ruby/power_assert/blob/297fa68908c45c4ca6c41e0940ebcc069744d580/lib/power_assert.rb#L39C11-L39C11) depends on byebug, but I think this method is only used by my PoC gem [pry-byebug-power_assert](https://github.com/k-tsj/pry-byebug-power_assert). So I'll remove this feature. (At least for now. I might implement the...
Thanks for reporting! For now, I'd prefer not to define `required_ruby_version`. I think power_assert should remain optional in something like test-unit, and I don't want to impose dependency requirements on...
FYI: https://github.com/ruby/test-unit-ruby-core/pull/21 > adding `required_ruby_version` to power_assert causes to fail the installation with old rubygems
@hsbt I'll release 3.0.0 this weekend. (I want to update the doc before that)