Results 16 comments of jingyang

> If I revert this commit I can do: --include-path ../external.txt:externals/external.txt and then reference externals/external.txt in the chart. I like this idea. I think this decouples how the chart was...

I was looking into this too, and was hoping to give it a try. But it seems like we may be blocked by https://gitlab.com/gitlab-org/gitlab/-/issues/250850

Related: https://github.com/golang/vscode-go/issues/128

Edited the original message to include the repro repo link. https://github.com/k-jingyang/vscode-go-issue-repro

> CC @hyangah @suzmue > > We thought that gcflags would be filtered out; needs further investigation. @findleyr I found the issue, https://github.com/golang/vscode-go/blob/master/src/goDebugConfiguration.ts#L396. The regexp does not allow whitespaces without...

As a workaround for anyone else encountering this. Splitting -N and -l into separate -gcflags works. ```json { "go.testFlags": ["-gcflags=all=-N", "-gcflags=all=-l"], } ```

Although we mentioned using BufReader instead of File in #9, I think that File is just enough abstraction to hold the file descriptor. Caching BufReader limits how we want to...

> `lsm-tree` currently uses `BufReader`, so it's not really compatible right now > > Also when using a `BufReader`, we can still look inside it to get the `File` Got...

> Probably should add a simple test for the FdCache (hit, no hit) Agree, I will follow up on this

> > Probably should add a simple test for the FdCache (hit, no hit) > > Agree, I will follow up on this Added the test in `basic_kv.rs`. Do let...